Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/ripple-tide-search): added missing aria-expanded to search filter toggle #859

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(@dpc-sdp/ripple-tide-search): added missing aria-expanded to search filter toggle #859

merged 1 commit into from
Sep 19, 2023

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1528

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit d6601e8
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/650922fe3e0404000827f047

@cypress
Copy link

cypress bot commented Sep 19, 2023

Passing run #704 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): added missing aria-expanded to search filter t...
Project: ripple-framework Commit: d6601e812b
Status: Passed Duration: 06:03 💡
Started: Sep 19, 2023 4:29 AM Ended: Sep 19, 2023 4:35 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit 70fe053 Sep 19, 2023
17 checks passed
@waitingallday waitingallday deleted the bugfix/R20-1528-search-expand-a11y branch October 25, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffdowdle @lambry @waitingallday @dylankelly